Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Hapi and Koa to default supported plugins #1440

Merged
merged 6 commits into from
Aug 19, 2020

Conversation

carolinee21
Copy link
Contributor

Short description of the changes:

  • Adds references to Hapi and Koa plugins in list of default supported plugins

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1440 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
- Coverage   93.89%   93.79%   -0.11%     
==========================================
  Files         148      144       -4     
  Lines        4393     4079     -314     
  Branches      894      847      -47     
==========================================
- Hits         4125     3826     -299     
+ Misses        268      253      -15     
Impacted Files Coverage Δ
packages/opentelemetry-node/src/config.ts 100.00% <ø> (ø)
...telemetry-plugin-fetch/src/enums/AttributeNames.ts
...ry-plugin-xml-http-request/src/enums/EventNames.ts
packages/opentelemetry-plugin-fetch/src/fetch.ts
...s/opentelemetry-plugin-xml-http-request/src/xhr.ts

@dyladan
Copy link
Member

dyladan commented Aug 18, 2020

Please add them to the plugins-node-all metapackage also.

@dyladan
Copy link
Member

dyladan commented Aug 19, 2020

Can you also add them to the metapackage?

@carolinee21
Copy link
Contributor Author

Can you also add them to the metapackage?

Yes sorry just added!

@carolinee21
Copy link
Contributor Author

Seems like the metapackage is currently failing to build because "'@opentelemetry/[email protected]' is not in the npm registry."
Should I wait for this to be published, or is there a better way to handle linking to an internal package?

@obecny
Copy link
Member

obecny commented Aug 19, 2020

Seems like the metapackage is currently failing to build because "'@opentelemetry/[email protected]' is not in the npm registry."
Should I wait for this to be published, or is there a better way to handle linking to an internal package?

I would rather block adding anything more to plugins-node-all until it will be moved to contrib repo due to the problems we already had with different version in a node_modules (sdk package), @dyladan WDYT ?

@dyladan
Copy link
Member

dyladan commented Aug 19, 2020

Seems like the metapackage is currently failing to build because "'@opentelemetry/[email protected]' is not in the npm registry."
Should I wait for this to be published, or is there a better way to handle linking to an internal package?

I would rather block adding anything more to plugins-node-all until it will be moved to contrib repo due to the problems we already had with different version in a node_modules (sdk package), @dyladan WDYT ?

Sure :)

@dyladan
Copy link
Member

dyladan commented Aug 19, 2020

@carolinee21 sorry to give you the runaround but can you remove the metapackage change for now?

@carolinee21
Copy link
Contributor Author

@carolinee21 sorry to give you the runaround but can you remove the metapackage change for now?

Yep, just did! Thanks

@dyladan dyladan merged commit ddd84ff into open-telemetry:master Aug 19, 2020
@obecny obecny added the enhancement New feature or request label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants