Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to getting started page #1673

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Conversation

lizsnyder
Copy link
Contributor

Which problem is this PR solving?

Making the text more clear, concise, readable, and consistent.

Short description of the changes

Wording changes, capitalization, rewording third-party speech, "we" speech, and forward-looking statements

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #1673 (a7ecd23) into master (400aff8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1673   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         165      165           
  Lines        5053     5053           
  Branches     1045     1045           
=======================================
  Hits         4617     4617           
  Misses        436      436           

@lizsnyder
Copy link
Contributor Author

@dyladan @legendecas @markwolff @mayurkale22 @mwear @naseemkullah any updates on this?

@dyladan
Copy link
Member

dyladan commented Nov 12, 2020

@dyladan @legendecas @markwolff @mayurkale22 @mwear @naseemkullah any updates on this?

All maintainers and approvers receive notifications when PRs and issues are opened. Please do not spam mentions.

@naseemkullah
Copy link
Member

A lot of these changes are good! Noticed the switching from we to you is following https://developers.google.com/style/person 👍

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment, otherwise LGTM

getting-started/README.md Outdated Show resolved Hide resolved
@lizsnyder
Copy link
Contributor Author

Thank you so much @naseemkullah and @mayurkale22. Could one of you please merge this PR for me? I don't have write access to the repo.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe one additional maintainer approval is still required to merge the PR according to the policy.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny merged commit 7242c76 into open-telemetry:master Nov 18, 2020
@naseemkullah
Copy link
Member

Hi @snyder114 I've mentioned your doc improvements on twitter here in response to Honeycomb looking for talent: https://twitter.com/naseemkullah/status/1331597502437535746 please let me know if thats ok or if you would prefer that be removed.

@lizsnyder lizsnyder deleted the patch-1 branch November 25, 2020 23:17
@lizsnyder
Copy link
Contributor Author

@naseemkullah thanks a lot! No that's no problem at all.

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants