-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to getting started page #1673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 165 165
Lines 5053 5053
Branches 1045 1045
=======================================
Hits 4617 4617
Misses 436 436 |
@dyladan @legendecas @markwolff @mayurkale22 @mwear @naseemkullah any updates on this? |
All maintainers and approvers receive notifications when PRs and issues are opened. Please do not spam mentions. |
A lot of these changes are good! Noticed the switching from we to you is following https://developers.google.com/style/person 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one minor comment, otherwise LGTM
Co-authored-by: Mayur Kale <[email protected]>
Thank you so much @naseemkullah and @mayurkale22. Could one of you please merge this PR for me? I don't have write access to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe one additional maintainer approval is still required to merge the PR according to the policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @snyder114 I've mentioned your doc improvements on twitter here in response to Honeycomb looking for talent: https://twitter.com/naseemkullah/status/1331597502437535746 please let me know if thats ok or if you would prefer that be removed. |
@naseemkullah thanks a lot! No that's no problem at all. |
Which problem is this PR solving?
Making the text more clear, concise, readable, and consistent.
Short description of the changes
Wording changes, capitalization, rewording third-party speech, "we" speech, and forward-looking statements