fix: remove default version from Tracer/Meter #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to spec the version is optional for Tracer and Meter. TracerProvider/MeterProvider should not add a default to ensure that exporters only export a version if supplied during creation.
Flarna
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 157 157
Lines 5108 5108
Branches 1091 1091
=======================================
Hits 4718 4718
Misses 390 390
|
Oberon00
reviewed
Jan 15, 2021
|
I support this change (but don't have the technical knowledge about OTel-JS to really review it). |
dyladan
approved these changes
Jan 15, 2021
vmarchaud
approved these changes
Jan 16, 2021
obecny
approved these changes
Jan 18, 2021
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…en-telemetry#1838) * test: fix TAV tests for @cucumber/cucumber and @aws-sdk/client-s3 - Switch to 'npm run --ws test-all-versions ...' for running TAV tests, instead of 'lerna run test-all-versions ...' because nx sets 'npm_config_legacy_peer_deps=true' which breaks '@cucumber/[email protected]' install and could break other installs by ignoring 'peerDependencies'. - Skip the bad '@aws-sdk/[email protected]' release in TAV tests. Also: - Reduce the number of versions of 'aws-sdk' and '@aws-sdk/*' packages test in TAV tests from 249, 143, and 132 versions currently, to 7 each. - Add a top-level `npm run test-all-versions` script to run that script in all packages that have one. This is the equivalent of the "test-all-versions.yml" CI workflow. Fixes: open-telemetry#1828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec the version is optional for
Tracerand `Meter.TracerProvider/MeterProvidershould not add a default to ensure that exporters only export a version if supplied during creation.Refs:
https:/open-telemetry/opentelemetry-specification/blob/v0.7.0/specification/trace/api.md#get-a-tracer
https:/open-telemetry/opentelemetry-specification/blob/v0.7.0/specification/metrics/api.md#obtaining-a-meter
I took a look into java and python and they don't default to
'*'.