fix(instrumentation-fetch): fetch(string, Request)
silently drops request body
#2411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
tl;dr: Fetch instrumentation drops request body when using
Request
object.Currently fetch instrumentation forwards calls via 2 parameter signature regardless if 'fetch(Request)
or
fetch(url, object)` signature is being used:opentelemetry-js/packages/opentelemetry-instrumentation-fetch/src/fetch.ts
Line 299 in 90ea0fe
This however is causing a bug where passing request object as 2nd parameter drops request body: https://jsfiddle.net/t2t2/bc53reqf/
(confirmed with both Firefox 90.0.2 & Chrome 92.0.4515.131)
In quick research found that while Request.body should return a
ReadableStream
none of the browsers actually do it right now.fetch(url, object)
is probably trying to find body from 2nd parameter as a normal object but isn't finding anything.Short description of the changes
In case of
fetch(Request)
call original method with the same signature.