Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hoist dependencies to speed up ci #2416

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 17, 2021

Similar to what @blumamir did in contrib

Also update dependencies which didn't match the hoisted versions in order to speed up the hoist.

Tests now run in under 5 minutes in CI with a cache miss

image

@dyladan dyladan requested a review from a team August 17, 2021 13:29
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2416 (5961f55) into main (40d0423) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5961f55 differs from pull request most recent head 08ca33d. Consider uploading reports for the commit 08ca33d to get more accurate results

@@            Coverage Diff             @@
##             main    #2416      +/-   ##
==========================================
+ Coverage   92.62%   92.66%   +0.04%     
==========================================
  Files         137      137              
  Lines        4975     4975              
  Branches     1048     1048              
==========================================
+ Hits         4608     4610       +2     
+ Misses        367      365       -2     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️
...emetry-api-metrics/src/platform/node/globalThis.ts 100.00% <0.00%> (+100.00%) ⬆️

@dyladan dyladan merged commit f129138 into open-telemetry:main Aug 17, 2021
@dyladan dyladan deleted the hoist-deps branch August 17, 2021 21:03
@Flarna
Copy link
Member

Flarna commented Aug 18, 2021

I have seen following warning in CI runs:

lerna WARN EHOIST_PKG_VERSION "backcompat-node10" package depends on @types/[email protected], which differs from the hoisted @types/[email protected].
lerna WARN EHOIST_PKG_VERSION "backcompat-node12" package depends on @types/[email protected], which differs from the hoisted @types/[email protected].
lerna WARN EHOIST_PKG_VERSION "backcompat-node8" package depends on @types/[email protected], which differs from the hoisted @types/[email protected].
lerna WARN EHOIST_PKG_VERSION "@opentelemetry/instrumentation-grpc" package depends on [email protected], which differs from the hoisted semver@^7.3.5.
lerna WARN EHOIST_PKG_VERSION "@opentelemetry/sdk-node" package depends on [email protected], which differs from the hoisted semver@^7.3.5.
lerna WARN EHOIST_PKG_VERSION "@opentelemetry/instrumentation" package depends on semver@^7.3.2, which differs from the hoisted semver@^7.3.5.
lerna WARN EHOIST_PKG_VERSION "@opentelemetry/exporter-collector-grpc" package depends on @grpc/grpc-js@^1.3.7, which differs from the hoisted @grpc/[email protected].
lerna WARN EHOIST_PKG_VERSION "@opentelemetry/instrumentation-grpc" package depends on @grpc/[email protected], which differs from the hoisted @grpc/proto-loader@^0.6.4.
lerna WARN EHOIST_PKG_VERSION "@opentelemetry/instrumentation" package depends on shimmer@^1.2.1, which differs from the hoisted [email protected].

In special the first few indicated that backcompat tests might be useless now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants