Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(opentelemetry-sdk-node): remove redundant judgments for metric #2648

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Dec 4, 2021

Signed-off-by: rickyes [email protected]

Which problem is this PR solving?

Remove redundant judgments for metricExporter.

Fixes # (issue)

Short description of the changes

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@rickyes rickyes requested a review from a team December 4, 2021 17:52
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #2648 (962453d) into main (3959386) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
- Coverage   93.10%   93.09%   -0.01%     
==========================================
  Files         123      123              
  Lines        4755     4753       -2     
  Branches     1060     1059       -1     
==========================================
- Hits         4427     4425       -2     
  Misses        328      328              
Impacted Files Coverage Δ
packages/opentelemetry-sdk-node/src/sdk.ts 77.41% <0.00%> (-0.71%) ⬇️

@dyladan dyladan merged commit b9e7835 into open-telemetry:main Dec 6, 2021
@rickyes rickyes deleted the refactor-sdk-node branch December 7, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants