Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused argument #3626

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Feb 22, 2023

Which problem is this PR solving?

Noticed while working on #3625.

Fixes # n/a

Short description of the changes

Just removing an unused argument

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

n/a

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@SimenB SimenB requested a review from a team February 22, 2023 07:15
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3626 (eeecb9b) into main (9b4f2a5) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head eeecb9b differs from pull request most recent head 3e1b954. Consider uploading reports for the commit 3e1b954 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
- Coverage   93.86%   93.84%   -0.02%     
==========================================
  Files         263      265       +2     
  Lines        7541     7371     -170     
  Branches     1575     1497      -78     
==========================================
- Hits         7078     6917     -161     
+ Misses        463      454       -9     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...ges/opentelemetry-instrumentation-http/src/http.ts
...es/opentelemetry-instrumentation-http/src/utils.ts
...y-instrumentation-http/src/enums/AttributeNames.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 97.02% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.59% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@pichlermarc
Copy link
Member

I'm having the same test failures in my PR/on main in my fork. I created an issue to track this #3628 🙂

@dyladan dyladan merged commit b73ba9c into open-telemetry:main Feb 22, 2023
@SimenB SimenB deleted the remove-unused-parameter branch February 22, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants