Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Node SDK example in README #3684

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

martinkuba
Copy link
Contributor

Which problem is this PR solving?

The start() method in the NodeSDK class has been recently updated to be synchronous (in #3460) - it no longer returns a promise. This is a minor update to the example in the corresponding README.

@martinkuba martinkuba requested a review from a team March 16, 2023 21:47
@martinkuba martinkuba changed the title Updated Trace SDK example in README Updated Node SDK example in README Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #3684 (0447cc5) into main (a96e429) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0447cc5 differs from pull request most recent head 9e8279f. Consider uploading reports for the commit 9e8279f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3684      +/-   ##
==========================================
+ Coverage   93.71%   93.73%   +0.01%     
==========================================
  Files         277      277              
  Lines        8454     8454              
  Branches     1761     1761              
==========================================
+ Hits         7923     7924       +1     
+ Misses        531      530       -1     

see 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs 🙂

@dyladan dyladan merged commit 7e9ff24 into open-telemetry:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants