feat(instrumentation): make InstrumentationAbstract.init public #4418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
For the esbuild instrumentation plugin I'm attempting to rely on
.init()
at build time to get info about instrumentations, and in order for that to typecheck I need public access to this method.Fixes # (issue)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Compile this package and use it in that plugin (locally).
In this repo:
npm run compile
cd experimental/packages/opentelemetry-instrumentation
npm pack
In my fork of the
opentelemetry-js-contrib
on theesbuild-plugin
branch (which is in the same directory asopentelemetry-js
)cd packages/esbuild-plugin-node
npm i ../../../opentelemetry-js/experimental/packages/opentelemetry-instrumentation-grpc/opentelemetry-instrumentation-0.47.0.tgz
Checklist: