fix(instr-fetch): do not enable in Node.js; clarify in docs this instr is for web fetch only #4498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side issue from #4496 was the mistaken use of instrumentation-fetch for Node.js's
fetch()
. instrumentation-fetch does not intend to handle Node.js's fetch.This change makes it so instrumentation-fetch will noop when used in Node.js.
Refs: #4496
Theoretically I think instrumentation-fetch should be able instrument Node.js fetch, but currently it is written with dependencies on a web otel package and its tests assume web/browser. See #4333 for discussion on instrumenting Node.js'
fetch()
.