Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare release 1.24.1/0.51.1 (backport bugfixes) #4682

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented May 6, 2024

Description

Backports bugfixes to 1.24.x and 0.51.x

Reason:

1.24.1

🐛 (Bug Fix)

  • fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used #4648 @pichlermarc
    • getEnvWithoutDefaults() would use process.env if it was defined when running in a browser, while getEnv() would always use _globalThis. Now both use _globalThis when running in a browser.
  • fix(resources): prevent circular import (resource -> detector -> resource -> ...) #4653 @pichlermarc
    • fixes a circular import warning which would appear in rollup when bundling @opentelemetry/resources
  • fix(exporter-metrics-otlp-grpc): add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc #4678 @AkselAllas

0.51.1

🐛 (Bug Fix)

pichlermarc and others added 6 commits May 6, 2024 16:04
…urce -> ...) (open-telemetry#4653)

* fix(resources): prevent circular import (resource -> detector -> resource -> ...)

* fixup! fix(resources): prevent circular import (resource -> detector -> resource -> ...)
…efaults() when a process polyfill is used (open-telemetry#4649)

* fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used

* Update CHANGELOG.md
open-telemetry#4678)

* fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc

* Update CHANGELOG.md

---------

Co-authored-by: Marc Pichler <[email protected]>
@pichlermarc pichlermarc changed the title chore: prepare release 1.24.1/0.51.1 chore: prepare release 1.24.1/0.51.1 (backport bugfixes) May 6, 2024
@pichlermarc pichlermarc marked this pull request as ready for review May 6, 2024 15:17
@pichlermarc pichlermarc requested a review from a team May 6, 2024 15:17
@dyladan
Copy link
Member

dyladan commented May 6, 2024

I reached out to Datadog about this through @Qard. As the PR currently stands it would break dd-trace which I would like to avoid. I think we should delay this for a short time in order to allow them to respond, but I don't want to delay it forever.

@pichlermarc
Copy link
Member Author

pichlermarc commented May 7, 2024

I reached out to Datadog about this through @Qard. As the PR currently stands it would break dd-trace which I would like to avoid. I think we should delay this for a short time in order to allow them to respond, but I don't want to delay it forever.

@dyladan this is a PR that just backports bugfixes, I think you meant to comment over at #4677 🙂

@dyladan
Copy link
Member

dyladan commented May 7, 2024

Thanks

@pichlermarc pichlermarc merged commit 41c2626 into open-telemetry:release/1.24.x-0.51.x May 7, 2024
16 checks passed
@pichlermarc pichlermarc deleted the release/1.24.x-0.51.x-2 branch May 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants