Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prometheus exporter readme with usage and links #521

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Add USAGE instructions.

/cc @dyladan

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #521 into master will increase coverage by 43.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #521       +/-   ##
===========================================
+ Coverage    49.2%   92.48%   +43.27%     
===========================================
  Files          47      146       +99     
  Lines        1392     7213     +5821     
  Branches      143      629      +486     
===========================================
+ Hits          685     6671     +5986     
+ Misses        707      542      -165
Impacted Files Coverage Δ
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-web/src/WebTracer.ts 100% <0%> (ø) ⬆️
...opentelemetry-core/src/trace/globaltracer-utils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/test/metrics/NoopMeter.test.ts 97.22% <0%> (ø)
...emetry-metrics/src/export/ConsoleMetricExporter.ts 93.75% <0%> (ø)
...entelemetry-plugin-dns/src/enums/AttributeNames.ts 100% <0%> (ø)
...ry-plugin-dns/test/functionals/dns-disable.test.ts 100% <0%> (ø)
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø)
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø)
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø)
... and 111 more

@mayurkale22 mayurkale22 added the document Documentation-related label Nov 12, 2019
@dyladan
Copy link
Member

dyladan commented Nov 13, 2019

LGTM. Maybe add a step to start prometheus with a docker command?

@mayurkale22
Copy link
Member Author

LGTM. Maybe add a step to start prometheus with a docker command?

https://opencensus.io/codelabs/prometheus/#0 <= link is already included for setup.

@mayurkale22 mayurkale22 merged commit 631d9e4 into open-telemetry:master Nov 14, 2019
@mayurkale22 mayurkale22 deleted the prom_readme branch November 14, 2019 19:19
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants