Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin(grpc): use HttpTextFormat instead of Binary propagator #762

Merged
merged 6 commits into from
Feb 22, 2020

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

/cc @markwolff @dyladan

@dyladan
Copy link
Member

dyladan commented Feb 20, 2020

@mayurkale22 the linked spec issue is merged now

@mayurkale22
Copy link
Member Author

@mayurkale22 the linked spec issue is merged now

Removed the onHold label, will create separate PR to remove BinaryFormat class.

packages/opentelemetry-plugin-grpc/src/grpc.ts Outdated Show resolved Hide resolved
setExtractedSpanContext(Context.ROOT_CONTEXT, spanContext),
carrier
);
for (const [k, v] of Object.entries(carrier)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this for now, but we should be using the new setter interface for propagators to handle this. https:/open-telemetry/opentelemetry-specification/blob/master/specification/api-propagators.md#setter-argument

@dyladan
Copy link
Member

dyladan commented Feb 20, 2020

Bummer that this will be broken/incompatible if you call an older version of ourselves now, but I suppose it had to be done

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #762 into master will decrease coverage by 22.13%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           master     #762       +/-   ##
===========================================
- Coverage   92.99%   70.86%   -22.14%     
===========================================
  Files         244       89      -155     
  Lines       10861     2313     -8548     
  Branches     1058      317      -741     
===========================================
- Hits        10100     1639     -8461     
+ Misses        761      674       -87
Impacted Files Coverage Δ
...metry-core/src/trace/sampler/ProbabilitySampler.ts 94.11% <66.66%> (-5.89%) ⬇️
...try-core/test/trace/fixtures/test-package/index.js 0% <0%> (-100%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0% <0%> (-100%) ⬇️
...st/trace/fixtures/test-package/foo/bar/internal.js 0% <0%> (-100%) ⬇️
...telemetry-core/test/platform/hex-to-base64.test.ts 0% <0%> (-100%) ⬇️
...ry-api/test/noop-implementations/noop-span.test.ts 0% <0%> (-100%) ⬇️
...-api/test/noop-implementations/noop-tracer.test.ts 0% <0%> (-100%) ⬇️
...ntelemetry-core/src/platform/node/hex-to-base64.ts 0% <0%> (-88.89%) ⬇️
...ckages/opentelemetry-core/test/platform/id.test.ts 0% <0%> (-77.78%) ⬇️
...entelemetry-core/test/common/ConsoleLogger.test.ts 0% <0%> (-77.02%) ⬇️
... and 229 more

@dyladan dyladan merged commit 03bf191 into open-telemetry:master Feb 22, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants