Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add express to default list of instrumented plugins #914

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • add express to default list of instrumented plugins

/cc @vmarchaud

@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #914 into master will decrease coverage by 1.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   94.32%   92.90%   -1.43%     
==========================================
  Files         245      244       -1     
  Lines       10970    10959      -11     
  Branches     1061     1064       +3     
==========================================
- Hits        10348    10181     -167     
- Misses        622      778     +156     
Impacted Files Coverage Δ
...entelemetry-core/test/context/B3Propagator.test.ts 45.53% <0.00%> (-54.47%) ⬇️
packages/opentelemetry-core/test/utils/url.test.ts 50.00% <0.00%> (-50.00%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50.00% <0.00%> (-50.00%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0.00%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 61.70% <0.00%> (-38.30%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0.00%> (-34.94%) ⬇️
...ckages/opentelemetry-core/test/platform/id.test.ts 66.66% <0.00%> (-33.34%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0.00%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 75.00% <0.00%> (-25.00%) ⬇️
...entelemetry-core/test/common/ConsoleLogger.test.ts 76.47% <0.00%> (-23.53%) ⬇️
... and 43 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that if we release #910 with it :)

@mayurkale22
Copy link
Member Author

I'm fine with that if we release #910 with it :)

Sure, will wait for #910 to merge.

@mayurkale22 mayurkale22 merged commit f73f48e into open-telemetry:master Apr 17, 2020
@mayurkale22 mayurkale22 deleted the express branch April 17, 2020 18:11
@mayurkale22 mayurkale22 restored the express branch April 17, 2020 18:11
@mayurkale22 mayurkale22 deleted the express branch April 17, 2020 18:11
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants