Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing empty tracestate header handling #936

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fixing empty tracestate header handling #936

merged 1 commit into from
Mar 16, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Mar 16, 2023

if an empty tracestate header was passed, we were emitting a warning (discovered in the demo app after enabling logging). to fix this, check for empty string as well as null.

if an empty tracestate header was passed, we were emitting a warning (discovered in the demo app after enabling logging).
to fix this, check for empty string as well as null.
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #936 (6a913bb) into main (88ea7c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6a913bb differs from pull request most recent head 17c2776. Consider uploading reports for the commit 17c2776 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #936   +/-   ##
=========================================
  Coverage     82.45%   82.46%           
- Complexity     1938     1939    +1     
=========================================
  Files           253      253           
  Lines          5518     5519    +1     
=========================================
+ Hits           4550     4551    +1     
  Misses          968      968           
Flag Coverage Δ
7.4 81.68% <100.00%> (+<0.01%) ⬆️
8.0 82.44% <100.00%> (+<0.01%) ⬆️
8.1 82.58% <100.00%> (+<0.01%) ⬆️
8.2 82.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Trace/TraceState.php 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ea7c3...17c2776. Read the comment docs.

@brettmc brettmc merged commit 0538a5a into open-telemetry:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants