Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Span status according to specification #224

Merged
merged 9 commits into from
Oct 27, 2020
Merged

Modify Span status according to specification #224

merged 9 commits into from
Oct 27, 2020

Commits on Oct 22, 2020

  1. Modify Span status according to specification 

    1. Renamed Status.code field to Status.deprecated_code.
2. Renamed Status.code.StatusCode enum to Status.DeprecatedStatusCode.
3. Introduce new Status.code with corresponding StatusCanonicalCode enum.
4. Added guidelines about how to use the fields to ensure backward compatibility.
    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    43378b8 View commit details
    Browse the repository at this point in the history

  2. Address PR comments

    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    5e88c59 View commit details
    Browse the repository at this point in the history

  3. Revert renaming of code to deprecated_code 

    We want to keep the old field and enum names.
    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    fd140af View commit details
    Browse the repository at this point in the history

  4. Get rid of "canonical" adjective

    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    42cc74c View commit details
    Browse the repository at this point in the history

  5. Revert "Get rid of "canonical" adjective" 

    This reverts commit b3b01e1.
    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    f2eb7fa View commit details
    Browse the repository at this point in the history

  6. Revert "Revert renaming of code to deprecated_code" 

    This reverts commit 6b9a7a4.
    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    95ee9fd View commit details
    Browse the repository at this point in the history

  7. Get rid of "canonical" adjective

    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    bc0050f View commit details
    Browse the repository at this point in the history

  8. Update removal date

    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    d21654b View commit details
    Browse the repository at this point in the history

  9. Change SHOULD->MUST, move comment section to the top.

    Tigran Najaryan committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    3edd5e7 View commit details
    Browse the repository at this point in the history