Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DoubleGaugeHistogram. #236

Closed
wants to merge 3 commits into from
Closed

Add DoubleGaugeHistogram. #236

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4221e21
Add AGGREGATION_TEMPORALITY_GAUGE.
imccarten1 Nov 13, 2020
17e8c23
Add the metric type DoubleGaugeHistogram.
imccarten1 Nov 15, 2020
4614d8e
Merge branch 'master' into gauge-aggregation
bogdandrutu Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,10 @@ enum AggregationTemporality {
// systems that do not use start_time to determine when the aggregation
// value was reset (e.g. Prometheus).
AGGREGATION_TEMPORALITY_CUMULATIVE = 2;

// GAUGE is an AggregationTemporality for a metric of type GAUGE. Essentially
// it means that aggregation over time is not being used.
AGGREGATION_TEMPORALITY_GAUGE = 3;
Copy link
Member

@bogdandrutu bogdandrutu Nov 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting because it does not apply to other places except where you wanted which is for Histogram to support OpenCensus and OpenMetrics concept of gauge Histograms.

I want others to comment, maybe we have a different type DoubleGaugeHistrogram

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I think adding a DoubleGaugeHistogram would be a tidier solution, but the lack of it seemed so odd, especially in comparison to the old open census types, that I assumed leaving it out was a deliberate decision. I'm happy to add it, instead of the aggregation_temporality_gauge, if people are ok with a new metric type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like more a new type.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the pull request to instead add a metric type DoubleGaugeHistogram

}

// IntDataPoint is a single data point in a timeseries that describes the
Expand Down