Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric.metadata for supporting additional metadata on metrics #514

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Add metric.metadata for supporting additional metadata on metrics #514

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e02ff11
add metric.attributes for supporting additional metadata on metrics
dashpole Nov 29, 2023
9d79fb2
clarifications around usage of metric.attributes
dashpole Dec 1, 2023
a716726
rename to metadata_attributes
dashpole Dec 8, 2023
928e06b
Update opentelemetry/proto/metrics/v1/metrics.proto
dashpole Dec 12, 2023
c067856
Merge branch 'main' into metric_attributes
dashpole Jan 10, 2024
a52118d
Merge branch 'main' into metric_attributes
arminru Jan 16, 2024
fc61d44
Add entry to CHANGELOG.md
arminru Jan 16, 2024
d80476d
Merge branch 'main' into metric_attributes
arminru Jan 31, 2024
2d23a97
Update opentelemetry/proto/metrics/v1/metrics.proto
dashpole Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,15 @@ message Metric {
ExponentialHistogram exponential_histogram = 10;
Summary summary = 11;
}

// Additional metadata attributes that describe the metric. [Optional].
// Attributes are non-identifying.
// Consumers SHOULD not need to be aware of these attributes.
dashpole marked this conversation as resolved.
Show resolved Hide resolved
// These attributes MAY be used to encode information allowing
// for lossless roundtrip translation to / from another data model.
// Attribute keys MUST be unique (it is not allowed to have more than one
// attribute with the same key).
repeated opentelemetry.proto.common.v1.KeyValue metadata = 12;
}

// Gauge represents the type of a scalar metric that always exports the
Expand Down
Loading