Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 1.1.0 #523

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Prepare release 1.1.0 #523

merged 5 commits into from
Jan 11, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team January 9, 2024 19:26
reyang
reyang reviewed Jan 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bogdandrutu
Prepare release 1.1.0
c79e2b6 
Signed-off-by: Bogdan Drutu <[email protected]>
@tigrannajaryan
Copy link
Member

LGTM.

The only functional change since 1.0 is #503 and it does not break stability guarantees, because it adds one field to existing message and adds a new enum. Both of this are explicitly allowed.

The release is a go.

@carlosalberto
Copy link
Contributor

#503 needs to be updated to the CHANGELOG btw. Do we want to hold this, in order to consider merging #484 and #514? Those two have been discussed enough (#484 needs final touches but overall seems good).

@bogdandrutu
Copy link
Member Author

#503 needs to be updated to the CHANGELOG btw.

What exactly?

Do we want to hold this, in order to consider merging #484 and #514? Those two have been discussed enough (#484 needs final touches but overall seems good).

I would do another review next month instead of rushing things.

@carlosalberto
Copy link
Contributor

Never mind on #503 - I had missed it.

Kielek
Kielek reviewed Jan 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
yurishkuro
yurishkuro approved these changes Jan 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@marcalff marcalff mentioned this pull request Jan 11, 2024
Closed
@bogdandrutu @yurishkuro
Update CHANGELOG.md
fc8fcfd 
Co-authored-by: Yuri Shkuro <[email protected]>
@bogdandrutu bogdandrutu merged commit 4ca4f03 into open-telemetry:main Jan 11, 2024
14 of 15 checks passed
@bogdandrutu bogdandrutu deleted the preparerelease branch January 11, 2024 16:54
@marcalff marcalff mentioned this pull request Jan 12, 2024
Open
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@bogdandrutu @Kielek
@yurishkuro @VinozzZ
Prepare release 1.1.0 (open-telemetry#523)
4c77d9f 
* Prepare release 1.1.0

Signed-off-by: Bogdan Drutu <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Piotr Kiełkowicz <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Yuri Shkuro <[email protected]>

---------

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@bogdandrutu @Kielek
@yurishkuro @VinozzZ
Prepare release 1.1.0 (open-telemetry#523)
7d00ec5 
* Prepare release 1.1.0

Signed-off-by: Bogdan Drutu <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Piotr Kiełkowicz <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Yuri Shkuro <[email protected]>

---------

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@bogdandrutu @Kielek
@yurishkuro @VinozzZ
Prepare release 1.1.0 (open-telemetry#523)
18d0564 
* Prepare release 1.1.0

Signed-off-by: Bogdan Drutu <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Piotr Kiełkowicz <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Yuri Shkuro <[email protected]>

---------

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@bogdandrutu @Kielek
@yurishkuro @VinozzZ
Prepare release 1.1.0 (open-telemetry#523)
e841efe 
* Prepare release 1.1.0

Signed-off-by: Bogdan Drutu <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Piotr Kiełkowicz <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Yuri Shkuro <[email protected]>

---------

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek left review comments

@reyang reyang reyang approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@arminru arminru arminru approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@jack-berg jack-berg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bogdandrutu @tigrannajaryan @carlosalberto @yurishkuro @Kielek @arminru @reyang @jack-berg