Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASGI] UnboundLocalError local variable 'start' referenced before assignment #1883

Closed
thomasleveil opened this issue Jul 10, 2023 · 0 comments · Fixed by #1889
Closed

[ASGI] UnboundLocalError local variable 'start' referenced before assignment #1883

thomasleveil opened this issue Jul 10, 2023 · 0 comments · Fixed by #1889

Comments

@thomasleveil
Copy link
Contributor

thomasleveil commented Jul 10, 2023 •
edited
Loading

This error arises when an exception occurs in this try block before the start = default_timer() line.

In such case the start variable is undefined. Unfortunately, the finally block tries to compute the duration using this variable.

Bug instroduced with cbf005b

related issue : #1478
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 14, 2023
@thomasleveil
[asgi] add test for open-telemetry#1883
e129541
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 14, 2023
@thomasleveil
[asgi] fix UnboundLocalError local variable 'start' referenced before…
a8495e0 
… assignment

see open-telemetry#1883
@thomasleveil thomasleveil mentioned this issue Jul 14, 2023
Merged
6 tasks
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 15, 2023
@thomasleveil
[asgi] add test for open-telemetry#1883
3f3fb7d
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 15, 2023
@thomasleveil
[asgi] fix UnboundLocalError local variable 'start' referenced before…
579e94d 
… assignment

see open-telemetry#1883
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 15, 2023
@thomasleveil
fixup! [asgi] add test for open-telemetry#1883
3d280b8
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 15, 2023
@thomasleveil
[asgi] add test for open-telemetry#1883
318cd04
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 15, 2023
@thomasleveil
[asgi] fix UnboundLocalError local variable 'start' referenced before…
9edfefb 
… assignment

see open-telemetry#1883
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 21, 2023
@thomasleveil
[asgi] add test for open-telemetry#1883
6ae8d62
thomasleveil added a commit to thomasleveil/opentelemetry-python-contrib that referenced this issue Jul 21, 2023
@thomasleveil
[asgi] fix UnboundLocalError local variable 'start' referenced before…
1def242 
… assignment

see open-telemetry#1883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@thomasleveil