-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SanitizeValue.sanitize_header_values()
type signature is incorrect
#2358
Comments
10 tasks
Fix proposed in #2361. |
Subtlety quote is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the case of WSGI request headers which come pre-joined, I think it makes sense to leave them comma separated. For WSGI response headers and ASGI overall, where we have access to repeated headers, it might make sense to use the list for the reasons you mentioned. I think that is the sprit of the spec when it says "depending on the way the HTTP library provides access to headers".
@ocelotl @xrmx any thoughts on this?
I was actually confused reading the code, because It looks like this signature for
SanitizeValue.sanitize_header_values()
is already wrong (it's returning adict[str, list[str]]
😓 Were there other signatures?Originally posted by @aabmass in #2266 (review)
The text was updated successfully, but these errors were encountered: