Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all the http server instrumentations to directly receive the excluded urls as a param #490

Open
cdvv7788 opened this issue May 9, 2021 · 0 comments

Comments

@cdvv7788
Copy link
Contributor

cdvv7788 commented May 9, 2021

Initially fixed for fastapi, instead of forcing the user to read the excluded_urls from environment, the option of passing the list directly as an argument allows to leverage other mechanisms (config, settings files, reading from env somewhere else, etc).

Is your feature request related to a problem?
Currently, if I don't provide an environment variable, there is no way to exclude_urls. Cannot modify them programmatically either (not in a straightforward way)

Describe the solution you'd like
The instrumentations have an optional parameter excluded_urls to pass this explicitly, using the environment variable as fallback.

Additional context
Related to: #375
Fastapi PR: #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant