Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PyMySQL v1.x series #791

Closed
owais opened this issue Nov 3, 2021 · 0 comments · Fixed by #792
Closed

Add support for PyMySQL v1.x series #791

owais opened this issue Nov 3, 2021 · 0 comments · Fixed by #792
Labels
feature-request

Comments

@owais
Copy link
Contributor

owais commented Nov 3, 2021

pymysql instrumentation does not work with 1.x series as it lists <1.0 as the compatible versions. I've tested the instrumentatoin with a simple application that uses PyMySQL 1.0 and it seems to work. We should update the instrumentation to support <2.0.

original issue: open-telemetry/opentelemetry-python#2259
@owais owais mentioned this issue Nov 3, 2021
Closed
owais added a commit to owais/opentelemetry-python-contrib that referenced this issue Nov 3, 2021
@owais
Support PyMySQL 1.x series
cffbc6c 
Fixes open-telemetry#791
@owais owais mentioned this issue Nov 3, 2021
Merged
11 tasks
owais added a commit to owais/opentelemetry-python-contrib that referenced this issue Nov 3, 2021
@owais
Support PyMySQL 1.x series
d7ec723 
Fixes open-telemetry#791
owais added a commit to owais/opentelemetry-python-contrib that referenced this issue Nov 3, 2021
@owais
Support PyMySQL 1.x series
8ea7c3e 
Fixes open-telemetry#791
owais added a commit to owais/opentelemetry-python-contrib that referenced this issue Nov 5, 2021
@owais
Support PyMySQL 1.x series
3498e8f 
Fixes open-telemetry#791
@owais owais closed this as completed in #792 Nov 6, 2021
owais added a commit that referenced this issue Nov 6, 2021
@owais
Support PyMySQL 1.x series (#792)
0c083ff 
Fixes #791
@zhihali zhihali mentioned this issue Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support PyMySQL 1.x series owais/opentelemetry-python-contrib
1 participant
@owais