Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with headers not being a dict in AWS lambda instr #1055

Merged
merged 6 commits into from Apr 25, 2022
Merged

Fixes issue with headers not being a dict in AWS lambda instr #1055

merged 6 commits into from Apr 25, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2022

Description

Fixes issue with AWS lambda - in some rare cases (API GW proxy integration test) headers are set to None, breaking context propagators.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • manual testing (pretty straightforward change)

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ghost ghost self-requested a review April 15, 2022 13:29
@srikanthccv srikanthccv merged commit fedf944 into open-telemetry:main Apr 25, 2022
@ghost
Copy link
Author

ghost commented Apr 26, 2022

TY @sanketmehta28 ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants