fix enable_commenter functionality #1440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix enable_commenter functionality.
Fixes #1368
Now you can either:
enable_commenter
param,like this:
note: it is important to import the
create_engine
function after callinginstrument()
:Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Now the tests are covering all 4 cases:
sqlcommenter enabled and disabled, both when instrumenting with engine, and when creating the engine after instrumentation.
test_sqlcommenter_disabled()
test_sqlcommenter_enabled()
test_sqlcommenter_enabled_create_engine_after_instrumentation()
test_sqlcommenter_disabled_create_engine_after_instrumentation()
Does This PR Require a Core Repo Change?
No.