Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to exclude some routes explicitly with Django Instrumentation #1618

Merged
merged 5 commits into from
Feb 3, 2023

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 2, 2023

We have exclude_lists via OTEL_PYTHON_DJANGO_EXCLUDED_URLS environment variable but not explicitly passed in through instrument().

@lzchen lzchen requested a review from a team February 2, 2023 21:28
@shalevr
Copy link
Member

shalevr commented Feb 2, 2023

Is there a test that moves excluded_urls directly to the instrumentation?

@lzchen lzchen merged commit 3770e57 into open-telemetry:main Feb 3, 2023
@lzchen lzchen deleted the exclude branch February 3, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants