Remove erroneous type attribute from asgi instrumentation

[samuelcolvin]

Description

As per #2055 (comment) this PR removes the undocumented and non-specific attribute type from opentelemetry-instrumentation-asgi.

Fixes #2055

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• none so far...

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: samuelcolvin / name: Samuel Colvin (a65d703, ea30627, e25d2cf, 58f49f2, 3d35f04, c7b000d)
• ✅ login: ocelotl / name: Diego Hurtado (02634c3)

[samuelcolvin]

I'd also be happy to change this to use a semconv HTTP attribute, but I couldn't see one that would be appropriate.

[shalevr]

Could you remove the type attribute from the tests?
in the test_asgi_middleware.py file

opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py

Line 641 in 6c13a5e

"type": "websocket",

[samuelcolvin]

Will do.

[alexmojaki]

How about renaming the attribute to asgi.event.type or asgi.message.type?

[samuelcolvin]

Okay, I've fixed tests, but on balance I think I agree with @alexmojaki that we should keep type but all it something more descriptive.

Could you remove the type attribute from the tests? in the test_asgi_middleware.py file

opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py

Line 641 in 6c13a5e

"type": "websocket",

No, that's the ASGI type in an ASGI scope, which has to be there. 🤦

[Kludex]

How about renaming the attribute to asgi.event.type or asgi.message.type?

Yeah. I'd call it asgi.event.type, but message and event are used as synonymous in the ecosystem.

[samuelcolvin]

replaced by #2300.