Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tornado instrumentation's usage of Span Status #504

Merged
merged 3 commits into from
May 24, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented May 22, 2021

Description

Tornado will only set Status description if the accompanying status_code
is an error status.

Fixes: #500

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais force-pushed the fix-tornado-set-span branch 3 times, most recently from f792f1e to f23529c Compare May 22, 2021 13:37
@owais owais marked this pull request as ready for review May 22, 2021 13:46
@owais owais requested review from a team, codeboten and srikanthccv and removed request for a team May 22, 2021 13:46
Tornado will only set Status description if the accompanying status_code
is an error status.
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
owais and others added 2 commits May 22, 2021 23:29
Co-authored-by: Srikanth Chekuri <[email protected]>
…telemetry/instrumentation/tornado/__init__.py

Co-authored-by: Srikanth Chekuri <[email protected]>
@lzchen lzchen merged commit f4a2b61 into open-telemetry:main May 24, 2021
@owais owais deleted the fix-tornado-set-span branch May 25, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tornado, getting "description should only be set when status_code is set to StatusCode.ERROR" for all spans
3 participants