Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new opentelemetry-contrib-instrumentations meta package #681

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

owais
Copy link
Contributor

@owais owais commented Sep 14, 2021

Description

This package does not contain any features on its own but serves is a
convenient way to install all supported instrumentations at once.

Also pins markupsafe to 2.0.1 in tests as 2.1.1 adding some breaking changes.

Type of change

Please delete options that are not relevant.

  • New package
  • Packaging fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested a review from a team September 14, 2021 17:02
@owais owais mentioned this pull request Sep 14, 2021
11 tasks
@owais owais force-pushed the instrumentation-meta-package branch from 17959d7 to 72edbbd Compare September 14, 2021 17:36
@owais owais force-pushed the instrumentation-meta-package branch 3 times, most recently from 813cd76 to a1756c3 Compare September 14, 2021 17:40
@codeboten
Copy link
Contributor

@owais we've come full circle 🤣 open-telemetry/opentelemetry-python#605

@owais
Copy link
Contributor Author

owais commented Sep 14, 2021

haha. I didn't know we considered it before I did not remember that. I think it is a lot more viable now that we don't pull in the frameworks we instrument with the instrumentations.

@ocelotl
Copy link
Contributor

ocelotl commented Sep 27, 2021

I am not sure this idea will age well. In some time there possibly will be other instrumentations developed by third parties and hosted in other repos. If that happens, should we rename this to opentelemetry-instrumentation-some? What if then someone releases the Some framework? How will we name the instrumentation for this framework?

Also, who is the intended end user? Someone who has a virtual environment where instrumentation for many frameworks happen?

@owais
Copy link
Contributor Author

owais commented Sep 27, 2021

I am not sure this idea will age well. In some time there possibly will be other instrumentations developed by third parties and hosted in other repos. If that happens, should we rename this to opentelemetry-instrumentation-some? What if then someone releases the Some framework? How will we name the instrumentation for this framework?

If it is an officially supported package by Python OpenTelemetry i.e, lives in the contrib repo then it'll be added as a dependency. Any 3rd party packages hosted by others on their own will not be added.

Also, who is the intended end user? Someone who has a virtual environment where instrumentation for many frameworks happen?

People who cannot or don't want to use an additional command (bootstrap) to install instrumentation packages and vendors who want to ship a UX where everything is bundled by default to reduce manual steps.

@owais
Copy link
Contributor Author

owais commented Sep 27, 2021

Perhaps opentelemetry-contrib-instrumentations would be a better name?

@ocelotl
Copy link
Contributor

ocelotl commented Sep 28, 2021

Perhaps opentelemetry-contrib-instrumentations would be a better name?

Yes, much better 👍

@lzchen
Copy link
Contributor

lzchen commented Feb 2, 2022

@owais
Are you still working on this PR?

@owais
Copy link
Contributor Author

owais commented Feb 2, 2022

I wanted to work on the opentelemetry package first but that got considerable push back. I'll revive this one next week.

@owais owais changed the title Added new opentelemetry-instrumentation-all meta package Added new opentelemetry-contrib-instrumentations meta package Feb 16, 2022
@owais owais force-pushed the instrumentation-meta-package branch 2 times, most recently from 88629d7 to ff0aa0a Compare February 16, 2022 02:29
@owais
Copy link
Contributor Author

owais commented Feb 16, 2022

@lzchen @ocelotl updated the PR with simpler implementation

@owais owais force-pushed the instrumentation-meta-package branch 9 times, most recently from 6e32962 to c2f03f6 Compare February 21, 2022 11:21
@lzchen
Copy link
Contributor

lzchen commented Feb 23, 2022

I wanted to work on the opentelemetry package first but that got considerable push back.

Curious, what was the pushback related to for this?

I think it is a lot more viable now that we don't pull in the frameworks we instrument with the instrumentations.

Was this the main issue for closing the previous PR?

docs-requirements.txt Outdated Show resolved Hide resolved
@owais owais force-pushed the instrumentation-meta-package branch from 69c7f87 to 4df8e41 Compare March 9, 2022 11:30
@owais
Copy link
Contributor Author

owais commented Mar 9, 2022

@ocelotl PTAL

@owais owais force-pushed the instrumentation-meta-package branch from a30ecd2 to 390ea26 Compare March 14, 2022 12:22
@owais
Copy link
Contributor Author

owais commented Mar 16, 2022

@ocelotl ping :)

@ocelotl
Copy link
Contributor

ocelotl commented Mar 16, 2022

@ocelotl ping :)

sorry! reviewing...

@ocelotl ocelotl merged commit 2f74c90 into open-telemetry:main Mar 17, 2022
@phillipuniverse
Copy link
Contributor

@owais @ocelotl it doesn't look like this got uploaded to Pypi? https://pypi.org/project/opentelemetry-contrib-instrumentations/

@lzchen
Copy link
Contributor

lzchen commented Apr 18, 2022

@phillipuniverse
My mistake, looks like it wasn't automatically released as part of the build. Will releasing shortly.

@lzchen
Copy link
Contributor

lzchen commented Apr 18, 2022

@phillipuniverse
https://pypi.org/project/opentelemetry-contrib-instrumentations/0.30b0/

@phillipuniverse
Copy link
Contributor

awesome, thanks @lzchen!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants