Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlalchemy for postgres Unix sockets #761

Merged
merged 10 commits into from
Nov 11, 2021

Commits on Oct 19, 2021

  1. Fix sqlalchemy for postgres unix sockets

    The following bit of replaced code contained a type inconsistency:
    
    ```py
    attrs[SpanAttributes.NET_PEER_PORT] = int(data.get("port"))
    ```
    
    `data.get` returns `Optional[str]` but `int(None)` throws a `TypeError`.
    
    When using postgresql via unix socket `dsn` looks something like this:
    
    ```py
    'user=postgres host=/tmp/socket dbname=postgres'
    ```
    
    The `parse_dsn` function returns this:
    
    ```py
    {'user': 'postgres', 'dbname': 'postgres', 'host': '/tmp/socket'}
    ```
    mattoberle committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    b03b44f View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG

    mattoberle committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    610ee1e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7103650 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48fd20e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    37ef73f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    68329b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Configuration menu
    Copy the full SHA
    8538e80 View commit details
    Browse the repository at this point in the history
  2. Fix formatting

    mattoberle committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    c4e9be1 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Configuration menu
    Copy the full SHA
    f906142 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    911305f View commit details
    Browse the repository at this point in the history