Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampler.ShouldSample parent parameter to be Context #1262

Closed
lzchen opened this issue Oct 21, 2020 · 0 comments · Fixed by #1267
Closed

Sampler.ShouldSample parent parameter to be Context #1262

lzchen opened this issue Oct 21, 2020 · 0 comments · Fixed by #1267
Assignees
@lzchen
Labels
good first issue Good first issue release:required-for-ga To be resolved before GA release

Comments

@lzchen
Copy link
Contributor

lzchen commented Oct 21, 2020

Specs: https:/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampler
PR: open-telemetry/opentelemetry-specification#881
@lzchen lzchen added good first issue Good first issue release:required-for-ga To be resolved before GA release labels Oct 21, 2020
@lzchen lzchen self-assigned this Oct 21, 2020
@lzchen lzchen mentioned this issue Oct 21, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@johnbley
feat(opentelemetry-web): capture encodedBodySize / http.response_cont…
85c430a 
…ent_length (open-telemetry#1262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
good first issue Good first issue release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass in context instead of parentcontext into samplers lzchen/opentelemetry-python
1 participant
@lzchen