Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _MILLIS from BatchSpanProcessor env and follow duration semantic conventions #1554

Closed
srikanthccv opened this issue Jan 27, 2021 · 1 comment
Closed

Remove _MILLIS from BatchSpanProcessor env and follow duration semantic conventions #1554

srikanthccv opened this issue Jan 27, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@srikanthccv
Copy link
Member

Duration input guidelines from spec and updated sdk env variables BSP. Probably we should address this after #1523 gets merged.
@srikanthccv srikanthccv added the bug Something isn't working label Jan 27, 2021
@srikanthccv srikanthccv changed the title Remove _MILLIS from BatchSpanProcessor and follow duration semantic conventions Remove _MILLIS from BatchSpanProcessor env and follow duration semantic conventions Jan 27, 2021
@codeboten codeboten mentioned this issue Jan 29, 2021
Merged
11 tasks
@srikanthccv
Copy link
Member Author

This is addressed in #1523 and it has enough approvals to merge hence closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srikanthccv