Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more restrictive typing to Log body field #4185

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Add more restrictive typing to Log body field #4185

merged 12 commits into from
Sep 30, 2024

Conversation

Ali-Alnosairi
Copy link
Contributor

@Ali-Alnosairi Ali-Alnosairi commented Sep 12, 2024 •
edited by emdneto
Loading

Description

Fixes #4124

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Ali-Alnosairi Ali-Alnosairi requested a review from a team September 12, 2024 01:13
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 12, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Ali-Alnosairi
Copy link
Contributor Author

Hi @lzchen ,
would you please take a look at this PR.

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Sep 17, 2024
@Ali-Alnosairi
Copy link
Contributor Author

Do we need to update changelog?

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 18, 2024
@Ali-Alnosairi
Copy link
Contributor Author

the public-symbols-check test keeps failing even after "Approve Public API check" was added !

@xrmx xrmx added Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary and removed Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Sep 18, 2024
@xrmx xrmx mentioned this pull request Sep 18, 2024
Merged
11 tasks
@Ali-Alnosairi Ali-Alnosairi requested a review from a team as a code owner September 23, 2024 13:16
@ocelotl ocelotl merged commit 6c4aed8 into open-telemetry:main Sep 30, 2024
378 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen left review comments

@xrmx xrmx xrmx approved these changes

@ocelotl ocelotl ocelotl approved these changes

@emdneto emdneto emdneto approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more informative/restrictive typing to Log body field
5 participants
@Ali-Alnosairi @xrmx @ocelotl @emdneto @lzchen