feat: Integration with V3 telemetry provider #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterapin
commented
Sep 27, 2024
jterapin
changed the title
jterapin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
alextwoods
reviewed
Sep 27, 2024
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/patches/telemetry.rb
Outdated
Show resolved
Hide resolved
alextwoods
reviewed
Sep 30, 2024
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/patches/telemetry.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@jterapin - Thanks for this PR! I'll take another look once you've added the HandlerHelper module. For now, the only thing that stands out to me is a comment about documentation.
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/handler_helper.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/handler.rb
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/messaging_helper.rb
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/handler_helper.rb
Show resolved
Hide resolved
kaylareopelle
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Thanks, @jterapin! I'll leave this open for a few more days to see if other folks want to review it. I'll merge next week unless there's more feedback.
xuan-cao-swi
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: AWS SDK for Ruby released Observability support, which allows the SDK to emit telemetry data based on OpenTelemetry. See OTelProvider for more details.
This PR addresses integration with the support mentioned above.
Other changes: