Update Instrument validation and move to SDK

[kaylareopelle]

Instrument name, unit, and version all have certain guidelines to adhere to. Currently, the logic to validate the instrument name is in the API, as part of OpenTelemetry::Metrics::Meter#create_instrument:

opentelemetry-ruby/metrics_api/lib/opentelemetry/metrics/meter.rb

Lines 58 to 70 in 0a474ef

	def create_instrument(kind, name, unit, description, callback, advice = nil)
	raise InstrumentNameError if name.nil?
	raise InstrumentNameError if name.empty?
	raise InstrumentNameError unless NAME_REGEX.match?(name)
	raise InstrumentUnitError if unit && (!unit.ascii_only? || unit.size > 63)
	raise InstrumentDescriptionError if description && (description.size > 1023 || !utf8mb3_encoding?(description.dup))
	@mutex.synchronize do
	OpenTelemetry.logger.warn("duplicate instrument registration occurred for instrument #{name}") if @instrument_registry.include? name
	@instrument_registry[name] = yield
	end
	end

Since the original implementation, the guidance has changed. The logic should now live in the SDK rather than the API.

Move the logic from the SDK to the API and verify that the validation procedures still match the spec.

• Instrument name syntax
• Instrument unit syntax
• Instrument description syntax

[github-actions]

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.