Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix intermittent logs test failures #1730

Merged

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Sep 19, 2024

Some tests in BatchLogRecordProcessor had timing issues due to the work method. Since we don't rely on that method for these tests, stub the work method to do nothing.

Co-authored-by: @tannalynn

Closes #1701

Note: A few open PRs contain skips for these tests. The skips should be removed once this PR is merged.

Some tests in BatchLogRecordProcessor had timing issues due to
the work method. Since we don't rely on that method for these tests,
stub the work method to do nothing.

Co-authored-by: Tanna McClure <[email protected]>
@kaylareopelle kaylareopelle changed the title test: Fix intermittent test failures test: Fix intermittent logs test failures Sep 19, 2024
@kaylareopelle kaylareopelle marked this pull request as ready for review September 19, 2024 23:56
@kaylareopelle kaylareopelle self-assigned this Sep 27, 2024
@mwear mwear merged commit 3c356fc into open-telemetry:main Oct 1, 2024
62 checks passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
@kaylareopelle kaylareopelle deleted the logs-intermittent-test-fixes branch October 11, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs SDK - Fix intermittently failing tests
2 participants