Added documentation for net_http gem in instrumentation #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shovnik
requested review from
dazuma,
ericmustin,
fbogsany,
mwear and
robertlaurin
as code owners
|
|
fbogsany
reviewed
Sep 17, 2020
instrumentation/net_http/README.md
Outdated
| @@ -0,0 +1,53 @@ | |||
| # OpenTelemetry Net::HTTP Instrumentation | |||
|
|
|||
| The OpenTelemetry Net::HTTP Ruby gem is a community maintained instrumentation for [Net::HTTP][net-http-home]. This is a toolkit that allows building HTTP user-agents. | |||
There was a problem hiding this comment.
Suggested change
| The OpenTelemetry Net::HTTP Ruby gem is a community maintained instrumentation for [Net::HTTP][net-http-home]. This is a toolkit that allows building HTTP user-agents. | |
| The OpenTelemetry Net::HTTP Ruby gem is a community maintained instrumentation for [Net::HTTP][net-http-home]. |
|
It did sound kind of awkward. I removed that line. |
mwear
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for Net HTTP Instrumentation. Should be similar to other recent documentation prs such as PR #386 . This hopefully resolves issue #238 .