prometheus: Ignore unknown instrument units #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation
The [metric unit semantic conventions] suggest that integer counts
should use annotations (e.g. `{packet}`), which breaks the current unit
appending logic as they are not properly escaped.
[metric unit semantic conventions]: https:/open-telemetry/semantic-conventions/blob/v1.23.0/docs/general/metrics.md#instrument-units
## Solution
Ignore unknown units (including annotations) as other language
implementations currently do. This change also removes the `$` mapping
as it is not UCUM.
jtescher
force-pushed
the
ignore-unknown-units
branch
from
a9936cc
to
707351a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
TommyCpp
reviewed
Nov 7, 2023
|
@TommyCpp yeah this seems to be the common choice currently (e.g. go, java, etc) |
TommyCpp
approved these changes
Nov 8, 2023
jtescher
added a commit
to jtescher/opentelemetry-rust-1
that referenced
this pull request
Nov 13, 2023
## Motivation
The [metric unit semantic conventions] suggest that integer counts
should use annotations (e.g. `{packet}`), which breaks the current unit
appending logic as they are not properly escaped.
[metric unit semantic conventions]: https:/open-telemetry/semantic-conventions/blob/v1.23.0/docs/general/metrics.md#instrument-units
## Solution
Ignore unknown units (including annotations) as other language
implementations currently do. This change also removes the `$` mapping
as it is not UCUM.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The metric unit semantic conventions suggest that integer counts should use annotations (e.g.
{packet}), which breaks the current unit appending logic as they are not properly escaped.Solution
Ignore unknown units (including annotations) as other language implementations currently do. This change also removes the
$mapping as it is not UCUM.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes