Skip to content

Commit

Permalink
code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Mateusz Rzeszutek committed Sep 17, 2021
1 parent 5b2f882 commit ad335c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion specification/trace/semantic_conventions/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ It is recommended to also use the general [network attributes][], especially `ne
Including all request/response headers can be a security risk - explicit configuration helps avoid leaking sensitive information.

Some HTTP headers - `Host` and `User-Agent` - are already captured in the `http.host` and `http.user_agent` attributes.
These headers SHOULD NOT be captured as a part of this convention.
Users MAY explicitly configure instrumentations to capture them even though it is not recommended.

**[2]:** The attribute value MAY contain separate header value as separate items, or concatenated header values as one item, depending on the way the HTTP library provides access to headers.

Expand Down

0 comments on commit ad335c1

Please sign in to comment.