Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to limit length of values of attributes and metric values #1133

Closed
jtmalinowski opened this issue Oct 22, 2020 · 4 comments · Fixed by #1130
Closed

Ability to limit length of values of attributes and metric values #1133

jtmalinowski opened this issue Oct 22, 2020 · 4 comments · Fixed by #1130
Labels
area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@jtmalinowski
Copy link
Contributor

To protect the backend which receives telemetry data it can be useful to set a limit on span attributes length (per attribute). Exceeding the limit causes truncation of given attribute value. By default, there would be no limit.

There is a precedent in Java implementation: open-telemetry/opentelemetry-java#1484
@jtmalinowski jtmalinowski added the spec:trace Related to the specification/trace directory label Oct 22, 2020
@jtmalinowski jtmalinowski mentioned this issue Oct 22, 2020
Merged
@Oberon00 Oberon00 added the area:sdk Related to the SDK label Oct 23, 2020
@Oberon00
Copy link
Member

The same probably applies to metric label values.

For key-like strings, there is a related issue #504.

@jtmalinowski
Copy link
Contributor Author

I'll extend the PR to include metric label values as well then.

@jtmalinowski jtmalinowski changed the title Ability to limit span attribute length Ability to limit length of values of span attributes and metric values Oct 23, 2020
@andrewhsu andrewhsu added release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs release:after-ga Not required before GA release, and not going to work on before GA and removed release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Oct 23, 2020
@andrewhsu
Copy link
Member

from the spec issue triage mtg today, marking as after-ga to bring in changes after GA release

@jtmalinowski
Copy link
Contributor Author

Based on @jmacd I've extended the scope of this to include all attributes (as in common).

@andrewhsu Does that mean we don't want to merge the PR until after GA?

@jtmalinowski jtmalinowski changed the title Ability to limit length of values of span attributes and metric values Ability to limit length of values of attributes and metric values Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
3 participants
@andrewhsu @jtmalinowski @Oberon00