Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use either SPAN or TRACES in all related environment variables #1352

Closed
carlosalberto opened this issue Jan 19, 2021 · 4 comments · Fixed by #1362
Closed

Use either SPAN or TRACES in all related environment variables #1352

carlosalberto opened this issue Jan 19, 2021 · 4 comments · Fixed by #1362
Assignees
@anuraaga
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory

Comments

@carlosalberto
Copy link
Contributor

Currently we are still mixing TRACE / SPAN in our environment variables, i.e. OTEL_TRACE_EXPORTER vs OTEL_EXPORTER_OTLP_SPAN_ENDPOINT. Decide which one is better and stick to that.
@carlosalberto carlosalberto added area:sdk Related to the SDK spec:trace Related to the specification/trace directory release:required-for-ga Must be resolved before GA release, or nice to have before GA priority:p1 Highest priority level labels Jan 19, 2021
@carlosalberto
Copy link
Contributor Author

Marking as Required-for-GA as we will have to do this change now or never.

@anuraaga anuraaga mentioned this issue Jan 20, 2021
Closed
@anuraaga anuraaga mentioned this issue Jan 22, 2021
Merged
@tedsuo
Copy link
Contributor

tedsuo commented Jan 25, 2021

Let's go with TRACE, please, it matches the name of the signal and the other non-OTLP env vars we already have.

@obecny
Copy link
Member

obecny commented Jan 25, 2021

+1 for TRACE

@mtwo
Copy link
Member

mtwo commented Jan 25, 2021

Following up from the maintainers meeting, we'll use TRACE

@carlosalberto carlosalberto changed the title Use either SPAN or TRACE in all related environment variables Use either SPAN or TRACES in all related environment variables Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anuraaga anuraaga

Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
5 participants
@tedsuo @anuraaga @carlosalberto @mtwo @obecny