Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide explicit override rules for AggregationTemporality across Exporters, Views and defaults. #2031

Closed
jsuereth opened this issue Oct 18, 2021 · 0 comments · Fixed by #2032
Assignees
Labels
area:sdk Related to the SDK enhancement New feature or request spec:metrics Related to the specification/metrics directory

Comments

@jsuereth
Copy link
Contributor

As a follow on to #2013 (and a discovery in open-telemetry/opentelemetry-java#3762), we should explicitly clarify the override rules of AggregationTemporality in the SDK.

Specifically:

  1. If a View is configured with explicit AggregationTemporality and an Exporter does not support it, what should happen?
  2. If a View is configured with explicit AggregationTemporality and an Exporter does not prefer it, what should happen?
  3. If a View is not configured with explicit AggregationTemporality and an Exporter does have a preference, what should happen?
  4. If a View is not configured with explicit AggregationTemporality and an Exporter does not have a preference, but supports either, which should be chosen?
  5. Should we allow CompositeExporter as a concept? Would this take the intersection of all allowed temporalitites?

Proposal

For reference, the Java implementation defines this in the following test.

  • View configuration takes precedence (even being chosen over supported temporality of exporters).
  • Exporter preferred temporality takes next precedence
  • Next, CUMULATIVE is chosen if nothing else has decided.
  • Lastly, DELTA wins if it's the only option left.

cc @reyang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK enhancement New feature or request spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants