Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move net.peer.name from common http attributes section to just client http attributes section #2366

Closed
trask opened this issue Feb 18, 2022 · 0 comments · Fixed by #2446
Closed

Move net.peer.name from common http attributes section to just client http attributes section #2366

trask opened this issue Feb 18, 2022 · 0 comments · Fixed by #2446
Assignees
@arminru
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Feb 18, 2022

What are you trying to achieve?

Help instrumenters avoid the problem we've run into in the opentelemetry-java-instrumentation project with triggering reverse name lookups (open-telemetry/opentelemetry-java-instrumentation#5297, open-telemetry/opentelemetry-java-instrumentation#5305, open-telemetry/opentelemetry-java-instrumentation#5393).

Given the problems this causes, I think it's worth moving net.peer.name from common http attributes section to just the client http attributes section (and add an explanation why it's not recommended for http server spans).
@trask trask added the spec:trace Related to the specification/trace directory label Feb 18, 2022
@arminru arminru added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Feb 22, 2022
@trask trask mentioned this issue Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arminru arminru

Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move net.peer.name from http common to http client trask/opentelemetry-specification
2 participants
@trask @arminru