Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Probability sampling algorithm. #31

Closed
songy23 opened this issue May 28, 2019 · 1 comment
Closed

Proposal: Probability sampling algorithm. #31

songy23 opened this issue May 28, 2019 · 1 comment
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK
Milestone

Comments

@songy23
Copy link
Member

songy23 commented May 28, 2019

Originates from open-telemetry/opentelemetry-java#337 (comment).

In Java we currently use:

We assume the lower 64 bits of the traceId's are randomly distributed around the whole (long)
range. We convert an incoming probability into an upper bound on that value, such that we can
just compare the absolute value of the id and the bound to see if we are within the desired
probability range. Using the low bits of the traceId also ensures that systems that only use 64
bit ID's will also work with this sampler.

@SergeyKanzhelev SergeyKanzhelev added this to the API complete milestone Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev added the area:sdk Related to the SDK label Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API complete, SDK complete Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev added area:sdk Related to the SDK and removed area:sdk Related to the SDK labels Jun 21, 2019
@iredelmeier iredelmeier added the area:sampling Related to trace sampling label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: SDK proposal complete, Alpha v0.3 Sep 27, 2019
@tedsuo
Copy link
Contributor

tedsuo commented Dec 4, 2019

OTEP #6 resolves this, so I am closing.

@tedsuo tedsuo closed this as completed Dec 4, 2019
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK
Projects
None yet
Development

No branches or pull requests

4 participants