-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 attributes to the semantic conventions for AWS SDK #3193
Comments
@willarmiros @iNikem @arminru As you were involved in the |
Hi @AlexanderWert - I love it, consider me in support. We also plan to add SQS attributes eventually as well! |
Hi @jmacd, Thanks! |
Feel free to create a Pr @AlexanderWert - and let's discuss the details on the PR itself, once people take a look, etc. Thanks! |
What are you trying to achieve?
There is a great set of attributes for DynamoDB-related spans in the semantic conventions for the AWS SDK.
Something similar would be also valuable for S3 operations. For example when a span is created for an S3
getObject
operation it would be interesting and valuable for analysis to know which S3bucket
and whichobject
is being accessed.I'm proposing to add relevant S3 specific attributes for the main S3 operations:
Bucket Operations
aws.s3.bucket
aws.s3.bucket
aws.s3.bucket
Object operations
aws.s3.bucket
,aws.s3.key
,aws.s3.copy_source
aws.s3.bucket
,aws.s3.key
aws.s3.bucket
,aws.s3.delete
aws.s3.bucket
,aws.s3.key
aws.s3.bucket
,aws.s3.key
aws.s3.bucket
aws.s3.bucket
aws.s3.bucket
aws.s3.bucket
,aws.s3.key
aws.s3.bucket
,aws.s3.key
aws.s3.bucket
,aws.s3.key
,aws.s3.input_serialization
,aws.s3.output_serialization
Multipart operations
aws.s3.bucket
,aws.s3.key
,aws.s3.upload_id
aws.s3.bucket
,aws.s3.key
,aws.s3.upload_id
aws.s3.bucket
,aws.s3.key
aws.s3.bucket
aws.s3.bucket
,aws.s3.key
,aws.s3.upload_id
aws.s3.bucket
,aws.s3.key
,aws.s3.upload_id
,aws.s3.part_number
aws.s3.bucket
,aws.s3.key
,aws.s3.upload_id
,aws.s3.part_number
,aws.s3.copy_source
The text was updated successfully, but these errors were encountered: