Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review existing "optional" attributes in hardware metrics #3236

Closed
trask opened this issue Feb 20, 2023 · 1 comment · Fixed by #3258
Closed

Review existing "optional" attributes in hardware metrics #3236

trask opened this issue Feb 20, 2023 · 1 comment · Fixed by #3258
Assignees
@bertysentry
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory

Comments

@trask
Copy link
Member

trask commented Feb 20, 2023

from @bertysentry's #3228 (comment):

The exact definition of Optional (i.e. really opt-in) was provided after I started working on the semantic conventions for hardware. Which lead to this confusion.
@trask trask added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Feb 20, 2023
@trask trask mentioned this issue Feb 20, 2023
Merged
@arminru arminru changed the title Review exiting "optional" attributes in hardware metrics Review existing "optional" attributes in hardware metrics Feb 22, 2023
@bertysentry
Copy link
Contributor

I will take care of this!

@trask trask assigned bertysentry and unassigned arminru Feb 24, 2023
@bertysentry bertysentry mentioned this issue Feb 27, 2023
Merged
jack-berg pushed a commit that referenced this issue Mar 25, 2023
@bertysentry
Issue #3236 Update attribute requirement levels in hardware metrics s…
68151ed 
…emconv (#3258)

Fixes #3236

## Changes

* Update attributes requirement levels in
`specification\metrics\semantic_conventions\hardware-metrics.md`
* Minor wording corrections
jack-berg added a commit that referenced this issue Mar 25, 2023
@jack-berg
Fix changelog
16733bb 
Followup to #3236.
@jack-berg jack-berg mentioned this issue Mar 25, 2023
Closed
jack-berg added a commit to jack-berg/opentelemetry-specification that referenced this issue Mar 27, 2023
@jack-berg
Fix changelog
c401b21 
Followup to open-telemetry#3236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertysentry bertysentry

Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #3236 Update attribute requirement levels in hardware metrics semconv
3 participants
@trask @arminru @bertysentry