-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly define CorrelationContext as an optional interface. #482
Comments
Added it to the (incoming) milestone 0.4.0. |
Copying/pasting a comment from @bogdandrutu on why we should recommend implementations to implement this (from #420): Here are some reasons why we need an explicit object called Correlation exposed:
For an experiment you can look at https:/grpc/grpc-java/blob/b7ccc0d14297f255557e67a4f0364480f4a80bcf/census/src/main/java/io/grpc/census/CensusStatsModule.java#L102 to see why a TagContext was needed in order to implement the tags propagation in gRPC. |
From the SIG mtg today, sounds like this one would be best to be bumped to the next milestone. |
from the issue triage mtg today with TC, allowing changes related to this issue for GA if editorial changes only |
From #420
This is a very important distinction that we want to make so languages keep a certain uniformity, and I do agree this the statement above, so we must add a note or a section that fully clarifies this one.
The text was updated successfully, but these errors were encountered: