Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: describe sampler API #53

Closed
SergeyKanzhelev opened this issue May 31, 2019 · 4 comments
Closed

API: describe sampler API #53

SergeyKanzhelev opened this issue May 31, 2019 · 4 comments
Labels
area:sampling Related to trace sampling

Comments

@SergeyKanzhelev
Copy link
Member

Document decisions made in Java repository: describe sampler API
@SergeyKanzhelev SergeyKanzhelev added this to the API complete milestone Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev self-assigned this Jun 6, 2019
@SergeyKanzhelev SergeyKanzhelev mentioned this issue Jun 7, 2019
Merged
@SergeyKanzhelev
Copy link
Member Author

I need to update the doc with AlwaysParent sampler.

@SergeyKanzhelev
Copy link
Member Author

See https:/open-telemetry/opentelemetry-java/issues/390

@SergeyKanzhelev
Copy link
Member Author

as related issue was moved to the next milestone, moving this one as well

@SergeyKanzhelev SergeyKanzhelev modified the milestones: API proposal done, API revision: 07-2019 Jun 8, 2019
@SergeyKanzhelev SergeyKanzhelev removed their assignment Jun 8, 2019
@iredelmeier iredelmeier added the area:sampling Related to trace sampling label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev removed this from the API revision: 07-2019 milestone Sep 27, 2019
@SergeyKanzhelev
Copy link
Member Author

This is done. See https:/open-telemetry/opentelemetry-specification/blob/master/specification/api-sampling.md

TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@rnburn
Add tsan build (open-telemetry#53)
cd620e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sampling Related to trace sampling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iredelmeier @SergeyKanzhelev