-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize the translation of OpenTracing references to span parent and links #562
Labels
area:sdk
Related to the SDK
priority:p2
Medium priority level
release:allowed-for-ga
Editorial changes that can still be added before GA since they don't require action by SIGs
spec:trace
Related to the specification/trace directory
Comments
@dmitryax Does this issue reflect some of your concern in open-telemetry/opentelemetry-collector#844? |
carlosalberto
added
the
release:required-for-ga
Must be resolved before GA release, or nice to have before GA
label
Jul 2, 2020
Talked to @carlosalberto, looks like this is a sub-issue of #114 |
Note from the maintainers meeting, @carlosalberto committed to completing this by the end of the week, which we need to do to hit our tracing spec RC deadlines. |
andrewhsu
added
priority:p2
Medium priority level
and removed
priority:p1
Highest priority level
labels
Sep 1, 2020
andrewhsu
added
release:allowed-for-ga
Editorial changes that can still be added before GA since they don't require action by SIGs
and removed
release:required-for-ga
Must be resolved before GA release, or nice to have before GA
labels
Sep 25, 2020
from the issue triage meeting today with TC, allowed for GA for editorial change only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:sdk
Related to the SDK
priority:p2
Medium priority level
release:allowed-for-ga
Editorial changes that can still be added before GA since they don't require action by SIGs
spec:trace
Related to the specification/trace directory
In the Java shim, the first reference is used as the parent regardless of the reference type: https:/open-telemetry/opentelemetry-java/blob/v0.3.0/opentracing_shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java#L74-L89
In Golang, its the first
CHILD_OF
: https:/open-telemetry/opentelemetry-go/blob/v0.4.2/bridge/opentracing/bridge.go#L540-L548In the Jaeger Java client, when spans are converted to thrift, the parent is set if and only if there is a single child reference: https:/jaegertracing/jaeger-client-java/blob/v1.2.0/jaeger-thrift/src/main/java/io/jaegertracing/thrift/internal/reporters/protocols/JaegerThriftSpanConverter.java#L50. I'm currently hitting this using the thrift HTTP receiver in the opentelemetry-collector. See jaegertracing/jaeger-client-java#705 for tracking this behaviour.
The spec should explicitly call out what the translation should be to avoid inconsistencies when translating to OTel.
The text was updated successfully, but these errors were encountered: