Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do we need @Nullable Boolean hasRemoteParent in shouldSample? #79

Closed
SergeyKanzhelev opened this issue Jun 7, 2019 · 3 comments
Closed

Why do we need @Nullable Boolean hasRemoteParent in shouldSample? #79

SergeyKanzhelev opened this issue Jun 7, 2019 · 3 comments
Labels
area:api Cross language API specification issue area:sampling Related to trace sampling

Comments

@SergeyKanzhelev
Copy link
Member

No description provided.

@SergeyKanzhelev SergeyKanzhelev added the area:api Cross language API specification issue label Jun 7, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the API revision: 07-2019 milestone Jun 7, 2019
@songy23
Copy link
Member

songy23 commented Jun 7, 2019

To support always-parent sampler, which I remember may become the default sampler.

@bogdandrutu
Copy link
Member

Not needed for the moment I think.

@iredelmeier iredelmeier added the area:sampling Related to trace sampling label Jul 30, 2019
@bogdandrutu
Copy link
Member

Closing this as a duplicate of #164

rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
@flands
Merge pull request open-telemetry#79 from signalfx/flands-patch-1
d5a6bb9 
Update CHANGELOG.md
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 21, 2024
@bogdandrutu @jkwatson @carlosalberto
Remove SamplingHint from the Sampling otep (open-telemetry#79)
66c4ee3 
* Remove SamplingHint from the Sampling otep

Signed-off-by: Bogdan Drutu <[email protected]>

* Update text/0006-sampling.md

Co-Authored-By: John Watson <[email protected]>

* Update text/0006-sampling.md

Co-Authored-By: John Watson <[email protected]>

Co-authored-by: John Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue area:sampling Related to trace sampling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bogdandrutu @iredelmeier @SergeyKanzhelev @songy23